Skip to content

Make type annotations of ColumnBase.find_and_replace stricter #20259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2025
Merged

Make type annotations of ColumnBase.find_and_replace stricter #20259

merged 4 commits into from
Oct 22, 2025

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Oct 14, 2025 •
edited
Loading

Description

Towards #20254

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Oct 14, 2025
@mroeschke mroeschke requested a review from a team as a code owner October 14, 2025 18:40
@mroeschke mroeschke added the Python Affects Python cuDF API. label Oct 14, 2025
@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 14, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 14, 2025
@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Oct 14, 2025
@mroeschke mroeschke changed the base branch from main to branch-25.12 October 20, 2025 23:04
@mroeschke mroeschke changed the base branch from branch-25.12 to main October 20, 2025 23:04
Matt711
Matt711 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware before reviewing this PR that ColumnLike is just an alias for Any. It might be possible be stricter in other places it's used too.

python/cudf/cudf/core/column/numerical.py
replacement_col = as_column(
replacement[0], length=len(to_replace_col), dtype=common_type
)
replacement_col = replacement_col.repeat(len(to_replace_col))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just because we prefer calling the pylibcudf API over as_column?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@mroeschke
Copy link
Contributor Author

I wasn't aware before reviewing this PR that ColumnLike is just an alias for Any. It might be possible be stricter in other places it's used too.

Yeah I think this annotation was added a placeholder to eventually make stricter than Any. I can look into it in the future

@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f7ffa6f into rapidsai:main Oct 22, 2025
265 of 267 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 22, 2025
@mroeschke mroeschke deleted the ref/cudf/column_typing1 branch October 22, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matt711 Matt711 Matt711 approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mroeschke @Matt711