Skip to content

Fix decimal dtype serialization in cudf-polars #20300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix decimal dtype serialization in cudf-polars #20300

wants to merge 6 commits into from
+62 −5

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 17, 2025 •
edited
Loading

Description

Explicitly serialize decimal dtypes to ensure Column.serialize_ctor_kwargs preserves them correctly. We could parse the _dtype_short_repr_to_dtype too but this change is more resilient to upstream polars changes I think.

Contributes to #19939

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner October 17, 2025 15:00
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Oct 17, 2025
@github-actions github-actions bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Oct 17, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 17, 2025
wence-
wence- reviewed Oct 17, 2025
View reviewed changes
@Matt711
Copy link
Contributor Author

Matt711 commented Oct 21, 2025

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wence- wence- wence- approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matt711 @wence-