Fix missing table compatibility check in two_table_comparator constructor #20305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
bdice
approved these changes
Oct 17, 2025
davidwendt
reviewed
Oct 18, 2025
shrshi
approved these changes
Oct 20, 2025
davidwendt
approved these changes
Oct 20, 2025
PointKernel
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a bug identified in #20301, where the preprocessed overload of the
two_table_comparatorconstructor failed to throw an error when the input tables were shape-incompatible, e.g. when one table had 3 columns and the other had 4.Checklist