Fix PCA sign flip #7331
Open
Fix PCA sign flip #7331
+296
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…element of each eigen-vector should be positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4560
This PR implemented PCA sign flip algorithm such that the max absolute value in each row is always positive in
components, leavingtrans_inputunchanged, just likesklearn.decomposition.PCA.In
_mgversion of PCA,componentsis not chunked. Thus, the_mgversion can reuse sign flipping from single-GPU version (by settingstream = streams[0]). In this PR,cuml\decomposition\sign_flip_mg.hppandcpp\src\pca\sign_flip_mg.cuare not in use (but the files are not removed).