Skip to content

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 14, 2025

Copy link

copy-pr-bot bot commented Oct 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
Copy link
Contributor Author

bdice commented Oct 14, 2025

/ok to test

@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2025

/ok to test

@bdice
Copy link
Contributor Author

bdice commented Oct 17, 2025

The build errors here seem to stem from a bunch of places in the source code where the extents type is left as default (uint32_t) or defined incorrectly. The previous mdspan implementation was willing to implicitly convert something like raft::make_device_matrix_view<const int64_t, uint64_t> to raft::make_device_matrix_view<const int64_t, int64_t>, unsafely casting uint64 to int64 in the extents type. The CCCL mdspan does not allow that. I am iterating through build errors to ensure that we have extent types properly defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant