update docs on using CI artifacts across PRs #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't have permissions to add reviewers in this repo, so tagging a few folks I expect would be interested: @vyasr @bdice @gforsyth @KyleFromNVIDIA @msarahan @divyegala |
msarahan
approved these changes
Feb 15, 2025
divyegala
reviewed
Feb 18, 2025
|
Thanks James! I forgot to follow up on this request with you, so thanks for remembering and following up. I have no review/merge powers here so I'll let @bdice take a look since he does. |
bdice
approved these changes
Feb 22, 2025
Comment on lines
+190
to
+192
| # make sure they can be found locally | ||
| conda config --system --add channels "${LIBRAFT_CHANNEL}" | ||
| conda config --system --add channels "${LIBRMM_CHANNEL}" |
There was a problem hiding this comment.
Note: this will change with rattler-build, which doesn't use the system conda config afaik. Should we preface this with that disclaimer?
| export PIP_CONSTRAINT=/tmp/constraints.txt | ||
| ``` | ||
|
|
||
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheels builds with e.g. `pip wheel`. |
There was a problem hiding this comment.
Suggested change
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheels builds with e.g. `pip wheel`. | |
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheel builds with e.g. `pip wheel`. |
| ``` | ||
|
|
||
| This should generally be enough. | ||
| If any of the other CI scripts are already setting environment variable `PIP_CONSTRAINT`, you may need to |
There was a problem hiding this comment.
Suggested change
| If any of the other CI scripts are already setting environment variable `PIP_CONSTRAINT`, you may need to | |
| If any of the other CI scripts are already setting the environment variable `PIP_CONSTRAINT`, you may need to |
| cat > /tmp/constraints.txt <<EOF | ||
| libkvikio-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${LIBKVIKIO_WHEELHOUSE}/libkvikio_*.whl) | ||
| librmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${LIBRMM_WHEELHOUSE}/librmm_*.whl) | ||
| rmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${RMM_WHEELHOUSE}/librmm_*.whl) |
There was a problem hiding this comment.
Suggested change
| rmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${RMM_WHEELHOUSE}/librmm_*.whl) | |
| rmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${RMM_WHEELHOUSE}/rmm_*.whl) |
| export PIP_CONSTRAINT=/tmp/constraints.txt | ||
| ``` | ||
|
|
||
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheels builds with e.g. `pip wheel`. |
There was a problem hiding this comment.
Suggested change
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheels builds with e.g. `pip wheel`. | |
| Then copy the following into every script in the `ci/` directory that is doing `pip` installs or wheel builds with e.g. `pip wheel`. |
| source ./ci/use_wheels_from_prs.sh | ||
| ``` | ||
|
|
||
| As above, if any of the other CI scripts are already setting environment variable `PIP_CONSTRAINT`, you may need to |
There was a problem hiding this comment.
Suggested change
| As above, if any of the other CI scripts are already setting environment variable `PIP_CONSTRAINT`, you may need to | |
| As above, if any of the other CI scripts are already setting the environment variable `PIP_CONSTRAINT`, you may need to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the 25.02 release, I worked through a bunch of PRs that relied on other PRs' wheels and conda packages, sometimes in a dependency chain 3 or 4 libraries deep.
This proposes some changes to the docs on how to do that. In general... instead of manually modifying every
ci/script, it's possible to put the changes into a singleci/use_{conda_packages,wheels}_from_prs.shthat is thensource'd into all scripts, reducing duplication and mistakes.