update docs on using CI artifacts across PRs #577
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I don't have permissions to add reviewers in this repo, so tagging a few folks I expect would be interested: @vyasr @bdice @gforsyth @KyleFromNVIDIA @msarahan @divyegala |
|
Thanks James! I forgot to follow up on this request with you, so thanks for remembering and following up. I have no review/merge powers here so I'll let @bdice take a look since he does. |
| # make sure they can be found locally | ||
| conda config --system --add channels "${LIBRAFT_CHANNEL}" | ||
| conda config --system --add channels "${LIBRMM_CHANNEL}" |
There was a problem hiding this comment.
Note: this will change with rattler-build, which doesn't use the system conda config afaik. Should we preface this with that disclaimer?
There was a problem hiding this comment.
I'd written this before I knew that: rapidsai/gha-tools#146 (comment)
I don't think we should add a disclaimer like that. A note of the form "this won't work for builds using rattler-build" isn't something that folks reading this could do much with, by themselves.
It'd be better to add "update the docs on using CI artifacts" as part of the work for rapidsai/build-planning#47
Co-authored-by: Bradley Dice <[email protected]>
During the 25.02 release, I worked through a bunch of PRs that relied on other PRs' wheels and conda packages, sometimes in a dependency chain 3 or 4 libraries deep.
This proposes some changes to the docs on how to do that. In general... instead of manually modifying every
ci/script, it's possible to put the changes into a singleci/use_{conda_packages,wheels}_from_prs.shthat is thensource'd into all scripts, reducing duplication and mistakes.