Add support for right join #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
requested review from
bdice,
devavret,
karthikeyann and
mhaseeb123
as code owners
karthikeyann
left a comment
karthikeyann
left a comment
There was a problem hiding this comment.
Looks good to me.
Since this code is handling multiple drivers, Please verify withVelox TPCH Benchmark with 2, 3, 4, 8 drivers.
Checking number of output rows should be enough.
|
Since our velox-cudf is updated upto Sept 5, created #61 from main-right-join branch. |
copy-pr-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
Add a new `ParquetConnector` and `ParquetDataSource` to read Parquet tables via cuDF backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to facebookincubator#14283
Adds support for right joins by batching the probe table and then applying left join with swapped left and right table.