Skip to content

feat: allow config service only on client#275

Open
ryangowe wants to merge 4 commits intorathole-org:mainfrom
ryangowe:feature/config_service_in_client
Open

feat: allow config service only on client#275
ryangowe wants to merge 4 commits intorathole-org:mainfrom
ryangowe:feature/config_service_in_client

Conversation

@ryangowe
Copy link
Copy Markdown

@ryangowe ryangowe commented Jul 23, 2023

Related to #161

允许server直接使用client对service的配置

在server启用

[server]
accept_client_recommend_service = true

[server.services] #这个东西现在还是必须要有

在client配置

[client.services.echo] 
local_addr = "127.0.0.1:8080" 
recommend_blind_addr = "0.0.0.0:2334"

@yujqiao
Copy link
Copy Markdown
Member

yujqiao commented Oct 1, 2023

Is it sending the configuration in plain text? That's something unfavored

@yujqiao yujqiao force-pushed the main branch 8 times, most recently from 78f1157 to 97541af Compare October 1, 2023 09:13
@ryangowe ryangowe force-pushed the feature/config_service_in_client branch from 37f3e79 to ca28e43 Compare October 11, 2023 13:46
@ryangowe
Copy link
Copy Markdown
Author

ryangowe commented Oct 11, 2023

I'm sending the configuration in plain text. Won't it be encrypted, even if 'transport.tls' is configured?

@ZHLHZHU
Copy link
Copy Markdown

ZHLHZHU commented Jan 26, 2024

any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryangowe @yujqiao @ZHLHZHU