Skip to content

[Core] Add virtual cluster #49717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Core] Add virtual cluster #49717

wants to merge 1 commit into from

Conversation

wumuzi520
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch 2 times, most recently from 55fbd08 to be1ee6b Compare January 8, 2025 13:43
@jjyao
Copy link
Collaborator

jjyao commented Jan 8, 2025

Hi @wumuzi520 is this the same virtual cluster as ray-project/enhancements#49 ?

@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch from b3e3150 to 8ea4728 Compare January 9, 2025 01:05
@wumuzi520
Copy link
Contributor Author

Hi @wumuzi520 is this the same virtual cluster as ray-project/enhancements#49 ?

Hi, @jjyao This PR is the implementation of an internal virtual cluster at Ant, and I have recently been working on the design document for this PR. Below is the expected appearance of the Virtual Cluster for this PR:

image

@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch from 8ea4728 to cf42af8 Compare January 9, 2025 04:26
@jjyao
Copy link
Collaborator

jjyao commented Jan 9, 2025

@wumuzi520 are you going to create a REP for it?

@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch 2 times, most recently from 5dec6f5 to a4ed432 Compare January 9, 2025 15:56
@wumuzi520 wumuzi520 requested review from a team and thomasdesr as code owners January 9, 2025 15:56
@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch 2 times, most recently from 9d67503 to 005d348 Compare January 9, 2025 16:08
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Jan 9, 2025
@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch from 005d348 to 56dd417 Compare January 10, 2025 08:16
@wumuzi520
Copy link
Contributor Author

@wumuzi520 are you going to create a REP for it?

Yes, we will submit a formal REP. Currently, there are still some minor bugs being fixed in the PR, and it is nearing completion. We are also in the process of writing detailed design documents.

@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch from 56dd417 to 59fc10b Compare January 13, 2025 02:34
@wumuzi520 wumuzi520 changed the title Add virtual cluster [Core] Add virtual cluster Jan 13, 2025
@aslonnie aslonnie removed their request for review January 13, 2025 19:10
@wumuzi520
add virtual cluster
03a7f06 
Signed-off-by: 黑驰 <[email protected]>
@wumuzi520 wumuzi520 force-pushed the add_virtual_cluster branch from 59fc10b to 03a7f06 Compare January 21, 2025 04:22
@wumuzi520 wumuzi520 requested a review from a team as a code owner January 21, 2025 04:22
@wumuzi520
Copy link
Contributor Author

Please refer to Ray Virtual Clusters for more details.

@stale Stale
Copy link

stale bot commented Feb 24, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Feb 24, 2025
@nadongjun
Copy link
Contributor

Is this PR still in progress?

@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 4, 2025
@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 4, 2025
@stale Stale
Copy link

stale bot commented May 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 6, 2025
can-anyscale
can-anyscale reviewed May 21, 2025
View reviewed changes
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it stale?

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@can-anyscale can-anyscale can-anyscale left review comments

@richardliaw richardliaw Awaiting requested review from richardliaw

@edoakes edoakes Awaiting requested review from edoakes

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@thomasdesr thomasdesr Awaiting requested review from thomasdesr thomasdesr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jjyao jjyao

@edoakes edoakes

Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wumuzi520 @jjyao @nadongjun @can-anyscale @edoakes @hainesmichaelc @jcotant1