[data.dashboard.x/01] fix operator state #52188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
changed the title
raulchen
reviewed
Apr 10, 2025
Comment on lines
429
to
440
| "state": DatasetState.FINISHED.name | ||
| if op_state.num_completed_tasks == op.num_outputs_total() | ||
| and op.num_outputs_total() > 0 | ||
| else state, |
There was a problem hiding this comment.
After this PR https://github.com/ray-project/ray/pull/52226/files, we can simplify this.
Suggested change
| "state": DatasetState.FINISHED.name | |
| if op_state.num_completed_tasks == op.num_outputs_total() | |
| and op.num_outputs_total() > 0 | |
| else state, | |
| "state": DatasetState.FINISHED.name if op.execution_complete() else state, |
There was a problem hiding this comment.
lol nice, i'll wait for it then; does it always FINISHED once completed or can be FAILED as well?
There was a problem hiding this comment.
No running tasks doesn't entail that operator is complete
There was a problem hiding this comment.
ok, let's merge the other PR then I'll follow @raulchen's approach
There was a problem hiding this comment.
only finished. we currently don't have failed state per op.
Signed-off-by: can <[email protected]>
Signed-off-by: can <[email protected]>
can-anyscale
force-pushed
the
can-dataop01
branch
from
a00b847 to
1250bed
Compare
|
@raulchen , @alexeykudinkin : updated, can you review, thankks |
raulchen
approved these changes
Apr 14, 2025
ktyxx
pushed a commit
to ktyxx/ray
that referenced
this pull request
Apr 29, 2025
Currently the operator state just mimics the entire dataset state, aka. they show as running even though they already finished. Fix it so that if the number of progress already equals to number of total, move it to FINISHED state. Test: - CI <img width="572" alt="Screenshot 2025-04-09 at 2 33 21 PM" src="https://github.com/user-attachments/assets/236ce1f8-05a8-4ab6-b8bf-2c651375c33e" /> --------- Signed-off-by: can <[email protected]>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
May 5, 2025
Currently the operator state just mimics the entire dataset state, aka. they show as running even though they already finished. Fix it so that if the number of progress already equals to number of total, move it to FINISHED state. Test: - CI <img width="572" alt="Screenshot 2025-04-09 at 2 33 21 PM" src="https://github.com/user-attachments/assets/236ce1f8-05a8-4ab6-b8bf-2c651375c33e" /> --------- Signed-off-by: can <[email protected]>
zhaoch23
pushed a commit
to Bye-legumes/ray
that referenced
this pull request
May 14, 2025
Currently the operator state just mimics the entire dataset state, aka. they show as running even though they already finished. Fix it so that if the number of progress already equals to number of total, move it to FINISHED state. Test: - CI <img width="572" alt="Screenshot 2025-04-09 at 2 33 21 PM" src="https://github.com/user-attachments/assets/236ce1f8-05a8-4ab6-b8bf-2c651375c33e" /> --------- Signed-off-by: can <[email protected]> Signed-off-by: zhaoch23 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the operator state just mimics the entire dataset state, aka. they show as running even though they already finished. Fix it so that if the number of progress already equals to number of total, move it to FINISHED state.
Test: