[rcore] fix crash in InitWindow, due to unchecked result of InitPlatform #4803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the result of InitPlatform(), if it isn't 0, report the Error and return. This prevent crashes and allows for gracefully aborting or recovering by checking IsWindowReady(). Partially-fixes: raysan5#4801
raysan5
reviewed
Mar 1, 2025
sleeptightAnsiC
added a commit
to sleeptightAnsiC/raylib
that referenced
this pull request
Mar 1, 2025
Small style change that doesn't impact how the code behaves here. Variable 'result' is not used anywhere else in this block, it's just for compliance with Raylib's coding conventions. Requested in PR: raysan5#4803 (comment)
raysan5
reviewed
Mar 2, 2025
raysan5
reviewed
Mar 2, 2025
Small style change that doesn't impact how the code behaves here. Variable 'result' is not used anywhere else in this block, it's just for compliance with Raylib's coding conventions. Requested in PR: raysan5#4803 (comment)
sleeptightAnsiC
force-pushed
the
fix_rcore__InitWindow_crash_when_InitPlatform_fails
branch
from
fc0af3c to
ead2952
Compare
...as this is preferred over LOG_ERROR. Requested-by: raysan5#4803 (comment)
|
Sorry for inconvenience @raysan5 |
|
@sleeptightAnsiC Thanks for the quick review! About the LOG_WARNING, I always try to give the user ownership over errors, as well as input provided info. |
Who is "the user" in this context? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the result of InitPlatform(), if it isn't 0, report the Error and return. This prevent crashes and allows for gracefully aborting or recovering by checking IsWindowReady().
I decided to use
LOG_ERRORhere, because this is a fatal error in most cases, and it will cause a crash when ignored. However, I'm not so sure aboutSYSTEMprefix. There was no good choice for it. It must be very generic because InitPlatform() can fail in multiple cases.Tested on native x86_64 Linux, and on x86_64 MacOS 13.6.9 running in VM. With GLFW in both cases.
Partially-fixes: #4801