-
Notifications
You must be signed in to change notification settings - Fork 13
feat: CalendarPreview date picker composition #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shreyag02
wants to merge
7
commits into
feat/calendar-preview-base
from
feat/calendar-preview-datepicker
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bcc77ec
feat: CalendarPreview date picker composition
Shreyag02 409a9bf
Merge branch 'feat/calendar-preview-base' into feat/calendar-preview-…
Shreyag02 ad368fc
fix(calendar-preview): let the popover be as wide as its grid
Shreyag02 1f13413
fix(calendar-preview): show the picker input's invalid state
Shreyag02 889e7d7
feat(calendar-preview): give the picker input a built-in error message
Shreyag02 af67961
docs(calendar-preview): document invalid typed dates
Shreyag02 3f49349
fix(calendar-preview): stop the picker input erasing Field's invalid …
Shreyag02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🤖 get_repo_knowledge executed:
get_repo_knowledge raystack/apsara /tmp/coderabbit-repo-knowledge/raystack-apsara-5863bde2/learningsLength of output: 2990
🏁 Script executed:
Repository: raystack/apsara
Length of output: 6827
🏁 Script executed:
Repository: raystack/apsara
Length of output: 4708
🏁 Script executed:
Repository: raystack/apsara
Length of output: 50373
Type both error states as
string | undefined.CalendarPreviewInputValidity.messageis optional and can be a string. A no-argumentReact.useState()infers an undefined-only state type, so the copied TSX example rejects both setter calls at Lines 378 and 399.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents