Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

feat: custom dashboard edit access #105

Open
amandal97 wants to merge 2 commits into
base: rzp_main
Choose a base branch
from
Open

feat: custom dashboard edit access #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c260d39
feat: custom dashboard edit access
amandal97 Nov 29, 2022
118bd10
feat: custom dashboard enable add panel and name edit
amandal97 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .../src/pages/custom-dashboards/custom-dashboard-detail/custom-dashboard-detail.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { DASHBOARD_VIEWS } from './../custom-dashboards-view.component';
<div class="dashboard-viewer">
<div class="header-container">
<ht-input
[disabled]="!isMyDashboard"
type="string"
class="dashboard-name-input"
appearance="${InputAppearance.Border}"
Expand All @@ -31,7 +30,7 @@ import { DASHBOARD_VIEWS } from './../custom-dashboards-view.component';
>
</ht-input>
<div class="actions">
<div class="button-container" *ngIf="isMyDashboard; else goBack">
<div class="button-container">
<ht-button
class="save-btn"
[label]="'Save'"
Expand All @@ -41,11 +40,6 @@ import { DASHBOARD_VIEWS } from './../custom-dashboards-view.component';
</ht-button>
<ht-button [label]="'Cancel'" role="${ButtonRole.Destructive}" (click)="redirectToListing()"> </ht-button>
</div>
<ng-template #goBack>
<div>
<ht-button [label]="'Go Back'" role="${ButtonRole.Destructive}" (click)="navigateBack()"> </ht-button>
</div>
</ng-template>
<ht-copy-to-clipboard
size="${ButtonSize.Small}"
icon="${IconType.Share}"
Expand All @@ -57,7 +51,6 @@ import { DASHBOARD_VIEWS } from './../custom-dashboards-view.component';
<div class="panels-list" *htLoadAsync="this.panels$ as panels">
<ht-custom-dashboard-panel
[panel]="panel"
[isOwner]="isMyDashboard"
*ngFor="let panel of panels"
(editPanel)="onPanelEdit($event)"
(deletePanel)="onPanelDelete($event)"
Expand All @@ -75,7 +68,7 @@ import { DASHBOARD_VIEWS } from './../custom-dashboards-view.component';
</ht-message-display>
</div>
</div>
<button *ngIf="isMyDashboard" class="add-panel" (click)="redirectToCreatePanel()">Add Panel +</button>
<button class="add-panel" (click)="redirectToCreatePanel()">Add Panel +</button>
</div>
`
})
Expand Down Expand Up @@ -193,12 +186,11 @@ export class CustomDashboardDetailComponent {
replaceCurrentHistory: false
});
}

public redirectToListing(): void {
const confirmation = confirm(`Your unsaved changes will be lost! Discard them anyways?`);
if (confirmation) {
this.navigateBack();
}
this.navigateBack();
}

public navigateBack(): void {
this.navigationService.navigate({
navType: NavigationParamsType.InApp,
Expand Down
5 changes: 1 addition & 4 deletions ...ty/src/pages/custom-dashboards/custom-dashboard-panel/custom-dashboard-panel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { ExploreSpecificationBuilder } from './../../../shared/graphql/request/b
<ht-panel-title [expanded]="expanded"
><span class="panel-title">{{ panel?.name || panel?.id }}</span>
</ht-panel-title>
<div class="actions-container" *ngIf="this.isOwner">
<div class="actions-container">
<ht-icon
title="Rename"
class="panel-icon panel-edit"
Expand Down Expand Up @@ -69,9 +69,6 @@ export class CustomDashboardPanelComponent implements OnInit {
@Input()
public panel?: PanelData;

@Input()
public isOwner: boolean = true;

@Output()
public readonly editPanel: EventEmitter<string> = new EventEmitter();

Expand Down