-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added locale for all countries [Fixes #176] #178
base: master
Are you sure you want to change the base?
Added locale for all countries [Fixes #176] #178
Conversation
|
@RgnDunes Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside flag can we have some text that describes the locale. Maybe the value of locale beside flag image
I have made the changes. Please check now @RgnDunes |
4d24ce4
to
104f5fe
Compare
Please check now @RgnDunes |
@saurabhdaware Please review |
Description
Added locale of all the countries present in the database (https://github.com/razorpay/i18nify/blob/master/i18nify-data/country/metadata/data.json) and using the same values to create the LANGS array of obj. [Fixes #176]
Changes Made
Added two ss to show of selecting different country.
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)