Skip to content

Add support for fetchpriority attribute to img #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piotrd wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add support for fetchpriority attribute to img #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f93fcba
Add 'fetchPriority' to common attributes list
piotrd Dec 16, 2025
98a34c2
Merge pull request #1 from piotrd/add-fetchpriority-attr
piotrd Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ export const COMMON_PROPS: (keyof Omit<ImageElementProps, 'src'>)[] = [
'srcSet',
'useMap',
'alt',
'fetchPriority'
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While adding fetchPriority here is correct, it's missing from the ImageElementProps type in src/interface.ts. This will cause a TypeScript compilation error because COMMON_PROPS is typed as (keyof Omit<ImageElementProps, 'src'>)[].

Please update ImageElementProps in src/interface.ts to include fetchPriority:

// src/interface.ts
export type ImageElementProps = Pick<
  React.ImgHTMLAttributes<HTMLImageElement>,
  | 'src'
  | 'crossOrigin'
  | 'decoding'
  | 'draggable'
  | 'loading'
  | 'referrerPolicy'
  | 'sizes'
  | 'srcSet'
  | 'useMap'
  | 'alt'
  | 'fetchPriority' // Add this line
>;

];