Skip to content

feat: Accessibility Updates #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chewnoill
Copy link
Contributor

@chewnoill chewnoill commented Jun 12, 2019

Allow popup list items to be selected with the keyboard

similar goal as #83

Jun-12-2019 16-43-09

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #153 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   91.05%   91.07%   +0.02%     
==========================================
  Files           7        7              
  Lines         380      381       +1     
  Branches       93       94       +1     
==========================================
+ Hits          346      347       +1     
  Misses         34       34
Impacted Files Coverage Δ
src/Select.jsx 89.28% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28755db...f5b5e89. Read the comment docs.

@afc163 afc163 changed the title Accessibility Updates feat: Accessibility Updates Jun 13, 2019
@afc163 afc163 merged commit 5364c25 into react-component:master Jun 13, 2019
@afc163
Copy link
Member

afc163 commented Jun 14, 2019

How can we tab from hour into minute panel, I can't handle it by keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants