chore: bump @rc-component deps #631
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@zombieJ has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Walkthrough此次更改主要集中在更新各处的模块导入路径和包配置。所有文件中原先从 Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
98-98: 考虑添加逗号以提高可读性在 "treeNodes data Array, if set it then you need not to construct children TreeNode" 这句中，可以考虑在 "if set it" 之前添加一个逗号，以提高可读性。
-| treeData | treeNodes data Array, if set it then you need not to construct children TreeNode. (value should be unique across the whole array) | array<{value,label,children, [disabled,selectable]}> | [] | +| treeData | treeNodes data Array, if set it, then you need not to construct children TreeNode. (value should be unique across the whole array) | array<{value,label,children, [disabled,selectable]}> | [] |🧰 Tools
🪛 LanguageTool
[typographical] ~98-~98: Consider adding a comma.
Context: ... | treeNodes data Array, if set it then you need not to construct children Tree...(IF_THEN_COMMA)
[grammar] ~98-~98: Did you mean “construct”?
Context: ...data Array, if set it then you need not to construct children TreeNode. (value should be uni...(NEEDNT_TO_DO_AND_DONT_NEED_DO)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
tests/__snapshots__/Select.spec.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (12)
README.md(1 hunks)examples/basic.tsx(4 hunks)examples/custom-icons.tsx(2 hunks)examples/filter.tsx(1 hunks)examples/width.tsx(1 hunks)now.json(0 hunks)src/OptionList.tsx(3 hunks)src/TreeSelect.tsx(7 hunks)src/TreeSelectContext.ts(1 hunks)tests/Select.props.spec.js(3 hunks)tests/Select.spec.tsx(2 hunks)tests/Select.warning.spec.js(1 hunks)
💤 Files with no reviewable changes (1)
- now.json
✅ Files skipped from review due to trivial changes (1)
- examples/custom-icons.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
- tests/Select.spec.tsx
- src/OptionList.tsx
- tests/Select.props.spec.js
- src/TreeSelect.tsx
🧰 Additional context used
🪛 LanguageTool
README.md
[typographical] ~98-~98: Consider adding a comma.
Context: ... | treeNodes data Array, if set it then you need not to construct children Tree...
(IF_THEN_COMMA)
[grammar] ~98-~98: Did you mean “construct”?
Context: ...data Array, if set it then you need not to construct children TreeNode. (value should be uni...
(NEEDNT_TO_DO_AND_DONT_NEED_DO)
[uncategorized] ~103-~103: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...nt.body;} | | autoClearSearchValue | auto clear search input value when multiple select...
(AUTO_HYPHEN)
🪛 markdownlint-cli2 (0.17.2)
README.md
100-100: Table column count
Expected: 4; Actual: 3; Too few cells, row will be missing data
(MD056, table-column-count)
🔇 Additional comments (13)
examples/width.tsx (1)
7-7: 属性名称更新正确将
dropdownMatchSelectWidth更新为popupMatchSelectWidth与 PR 中的其他文件变更保持一致，这反映了组件 API 命名的统一更新。examples/filter.tsx (1)
85-85: 样式属性名称更新正确将
dropdownStyle更新为popupStyle与整个代码库中的命名约定更新一致，保持了 API 的一致性。src/TreeSelectContext.ts (1)
8-8: 接口属性名称更新正确将
TreeSelectContextProps接口中的dropdownMatchSelectWidth属性更新为popupMatchSelectWidth，类型保持不变（boolean | number）。这一更改与其他文件中的命名更新保持一致。tests/Select.warning.spec.js (1)
3-3: 依赖路径更新正确将
resetWarned的导入路径从rc-util/lib/warning更新为@rc-component/util/lib/warning，这与此 PR 的目标（更新 @rc-component 依赖）一致。README.md (4)
64-64: 命名更新从dropdownMatchSelectWidth到popupMatchSelectWidth属性名从
dropdownMatchSelectWidth更新为popupMatchSelectWidth，保持了与代码库中其他地方的命名一致性。
65-66: 下拉框类名和样式的默认值更新
dropdownClassName的默认值从-更新为''（空字符串），dropdownStyle的默认值从-更新为{}（空对象），这更明确地表示了这些属性的默认值。
67-67: 从onDropdownVisibleChange更新为onPopupVisibleChange属性名从
onDropdownVisibleChange更新为onPopupVisibleChange，并明确了默认值为() => { return true; }，使其与代码库中的其他更改保持一致。
108-108: 为virtual属性添加了明确的默认值
virtual属性的默认值从-更新为明确的false，这使得文档更加清晰。examples/basic.tsx (5)
127-135: 方法名从onDropdownVisibleChange重命名为onPopupVisibleChange方法名已从
onDropdownVisibleChange更新为onPopupVisibleChange，与整个代码库中的命名约定保持一致。功能保持不变。
208-213: 事件处理函数属性名更新为onPopupVisibleChange在 TreeSelect 组件中，事件处理函数属性从
onDropdownVisibleChange更新为onPopupVisibleChange，保持了与组件 API 的一致性。
262-265: 属性名从dropdownAlign更新为popupAlign配置对象属性名从
dropdownAlign更新为popupAlign，保持了与其他类似属性重命名的一致性。
266-266: 使用更新后的onPopupVisibleChange方法TreeSelect 组件中的属性引用已更新为
onPopupVisibleChange，指向类中重命名后的方法。
330-330: 样式属性从dropdownStyle更新为popupStyleTreeSelect 组件中的样式属性从
dropdownStyle更新为popupStyle，保持了命名一致性。
| | treeNodeLabelProp | which prop value of treeNode will render as content of select | String | 'title' | | ||
| | treeData | treeNodes data Array, if set it then you need not to construct children TreeNode. (value should be unique across the whole array) | array<{value,label,children, [disabled,selectable]}> | [] | | ||
| | treeDataSimpleMode | enable simple mode of treeData.(treeData should be like this: [{id:1, pId:0, value:'1', label:"test1",...},...], `pId` is parent node's id) | bool/object{id:'id', pId:'pId', rootPId:null} | false | | ||
| | treeTitleRender | Custom render nodes | (nodeData: OptionType) => ReactNode | |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
表格列计数不一致
此行的列数（3）与预期的列数（4）不一致，可能会导致表格格式不正确。检查是否缺少了某个单元格。
🏁 Script executed:
#!/bin/bash
# 检查表格的列计数
cat README.md | grep -A 5 "| treeTitleRender" | tr -d '\n' | grep -o "|" | wc -lLength of output: 85
存在表格列数缺失
经过验证，README.md 中第 100 行对应的表格记录确实只包含 3 个单元格，而整个表格应保持 4 个单元格的一致性。这可能导致 Markdown 格式显示异常。建议检查该行及表格头部定义，并补充缺失的单元格以确保格式正确。
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
100-100: Table column count
Expected: 4; Actual: 3; Too few cells, row will be missing data
(MD056, table-column-count)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #631 +/- ##
===========================================
- Coverage 100.00% 99.83% -0.17%
===========================================
Files 16 16
Lines 598 593 -5
Branches 174 186 +12
===========================================
- Hits 598 592 -6
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
Summary by CodeRabbit
重构
TreeSelectContextProps接口中的属性dropdownMatchSelectWidth已更名为popupMatchSelectWidth。测试