Skip to content

fix: treat ctrl+click as right-click on macOS #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
STRML merged 1 commit into from
Dec 31, 2025
+2 −2
Merged

fix: treat ctrl+click as right-click on macOS #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/DraggableCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,8 @@
// Make it possible to attach event handlers on top of this one.
this.props.onMouseDown(e);

// Only accept left-clicks.
if (!this.props.allowAnyClick && typeof e.button === 'number' && e.button !== 0) return false;
// Only accept left-clicks. On macOS, ctrl+click is equivalent to right-click.
if (!this.props.allowAnyClick && ((typeof e.button === 'number' && e.button !== 0) || e.ctrlKey)) return false;

// Get nodes. Be sure to grab relative document (could be iframed)
const thisNode = this.findDOMNode();
Expand Down Expand Up @@ -377,7 +377,7 @@
try {
// $FlowIgnore
this.handleDragStop(new MouseEvent('mouseup'));
} catch (err) {

Check warning on line 380 in lib/DraggableCore.js

View workflow job for this annotation

GitHub Actions / lint 

'err' is defined but never used
// Old browsers
const event = ((document.createEvent('MouseEvents'): any): MouseTouchEvent);
// I see why this insanity was deprecated
Expand Down
Loading