Skip to content

fix(android): remove unnecessary getViewManagers overrides #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
+8 −12
Merged

fix(android): remove unnecessary getViewManagers overrides #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a681f42
fix(android): remove unnecessary `getViewManagers` overrides
tido64 Feb 24, 2025
aa64f5d
disable Jetifier
tido64 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-pianos-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-native-async-storage/async-storage": patch
---

Remove unnecessary `getViewManagers` overrides
7 changes: 1 addition & 6 deletions ...droid/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
)
public class AsyncStoragePackage extends TurboReactPackage {

@Override
protected List<ModuleSpec> getViewManagers(ReactApplicationContext reactContext) {
return null;
}

@Override
public NativeModule getModule(String name, @Nonnull ReactApplicationContext reactContext) {
switch (name) {
Expand Down Expand Up @@ -95,4 +90,4 @@ public Map<String, ReactModuleInfo> getReactModuleInfos() {
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
return Collections.emptyList();
}
}
}
4 changes: 1 addition & 3 deletions ...droid/src/kotlinPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,4 @@ class AsyncStoragePackage : TurboReactPackage() {
throw RuntimeException("No ReactModuleInfoProvider for AsyncStoragePackage$\$ReactModuleInfoProvider", e)
}
}

override fun getViewManagers(reactContext: ReactApplicationContext?): MutableList<ModuleSpec>? = null
}
}
4 changes: 1 addition & 3 deletions packages/default-storage/example/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryEr
# https://developer.android.com/topic/libraries/support-library/androidx-rn
android.useAndroidX=true
# Automatically convert third-party libraries to use AndroidX
android.enableJetifier=true
# Jetifier randomly fails on these libraries
android.jetifier.ignorelist=hermes-android
android.enableJetifier=false

# Use this property to specify which architecture you want to build.
# You can also override it from the CLI using
Expand Down