-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(0.79): generate codegen before pod install
#2600
base: main
Are you sure you want to change the base?
feat(0.79): generate codegen before pod install
#2600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments to make the code more maintainable!
But thank you for implementing this.
|
||
interface PodInstallOptions { | ||
skipBundleInstall?: boolean; | ||
newArchEnabled?: boolean; | ||
iosFolderPath?: string; | ||
platform: string; | ||
root: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the location of the xcodeproj
file. f that's the case, we are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szymonrybczak let's call this cariable sourceDir
instead of root
then and pass proper value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, root
is where package.json
should be - based on this code:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for applying the suggestions!
Summary
Starting from React Native 0.79
pod install
won't invoke codegen generation logic so we have to do inside CLI.Test Plan
yarn ios
in your project should generate codegen underios/build
and install Cocoapods properly.Checklist
react-native
checkout (instructions).