feat: ✨ enables theme overlays for material 3 date pickers#961
Merged
vonovak merged 2 commits intoreact-native-datetimepicker:masterfrom May 26, 2025
Merged
Conversation
dsoffiantini
force-pushed
the
material-theme-support
branch
from
bdb990c to
ea293f9
Compare
sidorchukandrew
approved these changes
Mar 10, 2025
Member
|
hello @dsoffiantini, It'd be nice to have the test plan filled out (for maintainers, for everyone reading the PR), but I'll trust this is a good change and merge without it. Thank you |
vonovak
pushed a commit
that referenced
this pull request
May 26, 2025
# [8.4.0](v8.3.0...v8.4.0) (2025-05-26) ### Features * **android:** ✨ enables theme overlays for material 3 date pickers ([#961](#961)) ([612a197](612a197))
Member
|
🎉 This issue has been resolved in version 8.4.0 🎉 If this package helps you, consider sponsoring us! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR retrieves the resource ID of the materialCalendarTheme specified by the user inside
styles.xml, which will default to the material 3 theme if not specified. This enables theming the date picker component when using Material 3 instead of user styling being overridden by the default theme.Issue: #960
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)