Housekeeping: Add Net10, Remove obsolete FilterOnProperty #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the obsolete FilterOnProperty extension and related tests. Updated .NET workflow to support .NET 10 and improved caching. Upgraded package dependencies in Directory.Build.props and test project. Updated copyright years.
JakenVeina
requested changes
Nov 13, 2025
Collaborator
JakenVeina
left a comment
JakenVeina
left a comment
There was a problem hiding this comment.
We'll need a major version bump for the removal of obsolete APIs, I think, in which case there's at least one other outstanding PR that's been waiting for a major version bump. We should make sure and pull it before releasing.
| public static class ObsoleteEx | ||
| { | ||
| } | ||
| public static class ObsoleteEx; |
Collaborator
There was a problem hiding this comment.
If we're making breaking changes to remove obsolete methods anyway, should we remove this too?
| 9.0.x | ||
| 10.0.x | ||
| dotnet-quality: 'preview' |
Collaborator
There was a problem hiding this comment.
It looks like the indentation is off here, and is causing the build to fail. dotnet-quality, cache, and cache-dependency-path I should all be indented to the same level as dotnet-version.
Member
There was a problem hiding this comment.
Don't need the dotnet-quality of preview now that .net 10 is out anwyay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the obsolete FilterOnProperty extension and related tests.
Updated .NET workflow to support .NET 10 and improved caching.
Upgraded package dependencies in Directory.Build.props and test project.
Updated copyright years.