fix: stop removing trailing single chars from query string #2045
+45
−5
Annotations
10 warnings
|
Build (dotnet):
Refit/RequestBuilder.cs#L8
Missing XML comment for publicly visible type or member 'IRequestBuilder'
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L161
Type 'SyntaxReceiver' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/Emitter.cs#L320
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'Refit.Generator.Emitter.WriteMethodOpening(Refit.Generator.SourceWriter, Refit.Generator.MethodModel, bool, bool, bool)' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/Emitter.cs#L340
Use 'StringBuilder.Append(char)' instead of 'StringBuilder.Append(string)' when the input is a constant unit string (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L23
Unused field 'TypeParameterVariableName' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/Emitter.cs#L191
Method WriteRefitMethod passes 'ReturnTypeMetadata' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/Parser.cs#L46
Prefer the generic overload 'Refit.Generator.WellKnownTypes.Get<T>()' instead of 'Refit.Generator.WellKnownTypes.Get(System.Type)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2263)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/Polyfills/IndexRange.cs#L58
Provide a method named 'ToIndex' or 'FromInt32' as an alternate for operator op_Implicit (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2225)
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/UniqueNameBuilder.cs#L6
Missing XML comment for publicly visible type or member 'UniqueNameBuilder.UniqueNameBuilder()'
|
|
Build (dotnet):
InterfaceStubGenerator.Shared/UniqueNameBuilder.cs#L6
Missing XML comment for publicly visible type or member 'UniqueNameBuilder'
|
Loading