Skip to content

Refactor to adhere to React best practices #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cipherlogs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor to adhere to React best practices #5630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
273129d
Refactor data flow to adhere to React best practices
cipherlogs Feb 25, 2023
f605644
Refactor async with promises to make the example easy to understand
cipherlogs Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions beta/src/content/learn/you-might-not-need-an-effect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,13 +597,21 @@ function Parent() {
}

function Child({ onFetched }) {
const data = useSomeAPI();

// 🔴 Avoid: Passing data to the parent in an Effect
useEffect(() => {
if (data) {
onFetched(data);
}
}, [onFetched, data]);
let canRun = true;

useSomeAPI().then(data => {
if (data && canRun) {
onFetched(data);
}
});

// clean up
return () => (canRun = false);
}, [onFetched]);

// ...
}
```
Expand All @@ -612,7 +620,21 @@ In React, data flows from the parent components to their children. When you see

```js {4-5}
function Parent() {
const data = useSomeAPI();
const [data, setData] = useState(null);

useEffect(() => {
let canRun = true;

useSomeAPI().then(fetchedData => {
if (fetchedData && canRun) {
setData(fetchedData);
}
});

// clean up
return () => (canRun = false);
}, []);

// ...
// ✅ Good: Passing data down to the child
return <Child data={data} />;
Expand Down