Don't run requests through configuration middleware #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
dont-run-configuration-middleware
branch
from
e9e2342 to
fdd77ad
Compare
clue
reviewed
Aug 20, 2021
While working on another PR that introduces another configuration middleware it dawned on me that we preferably don't requests through middleware that don't do anything. This change will filter it out those middleware before they are passed into the MiddlewareRunner. While running benchmarks I gained around a 10% requests per second gain when running it against example 63.
WyriHaximus
force-pushed
the
dont-run-configuration-middleware
branch
from
fdd77ad to
871edea
Compare
clue
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
Hm, just noticed the build currently fails, can you look into this?
Already looking into that, not sure why they suddenly started failing, because they now also fail locally, even when I revert the changes 0_o |
|
@clue Both locally and on GitHub that tests now runs fine, without any changes 🤯 . (Restarted it 5 times or so, green every time now.) |
clue
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
@WyriHaximus Sounds good to me, looks like we should look into the flaky test in a separate PR, looks like it's unrelated anyway 👍
|
@clue Agreed, although I'm not sure why that test took more then 10 seconds |
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 22, 2021
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 22, 2021
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 30, 2021
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Nov 9, 2021
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Nov 9, 2021
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 22, 2022
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 16, 2022
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Aug 27, 2022
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Sep 14, 2022
This new middleware introduces a timeout of closing inactive connections between connections after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Sep 15, 2022
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 25, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 25, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 25, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 26, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 26, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 26, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 26, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 26, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 30, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 30, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 30, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Mar 30, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Apr 6, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Apr 10, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
WyriHaximus
added a commit
to WyriHaximus-labs/http
that referenced
this pull request
Apr 10, 2024
This new middleware introduces a timeout of closing inactive connections between requests after a configured amount of seconds. This builds on top of reactphp#405 and partially on reactphp#422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another PR that introduces another configuration middleware it dawned on me that we preferably don't requests through middleware that don't do anything.
This change will filter it out those middleware before they are passed into the MiddlewareRunner.
While running benchmarks I gained around a 10% requests per second gain when running it against example 63.