Allow psr/http-message ^2.0 #542
Conversation
Requires php: ^7.2 || ^8.0 Closes reactphp#513
|
@clue @WyriHaximus would it be possible to get some eyes on this and released if all good? |
| @@ -29,7 +29,7 @@ | |||
| "php": ">=7.1", | |||
| "evenement/evenement": "^3.0 || ^2.0 || ^1.0", | |||
| "fig/http-message-util": "^1.1", | |||
| "psr/http-message": "^1.0", | |||
| "psr/http-message": "^2.0 || ^1.0", | |||
There was a problem hiding this comment.
The only way this will work is if we go:
| "psr/http-message": "^2.0 || ^1.0", | |
| "psr/http-message": "^2.0", |
Reason for this is that we have a bunch of messages in https://github.com/reactphp/http/tree/3.x/src/Message that don't have a return type on those methods. If we'll allow 2.0 without adding that you'll get fatal errors, so IMHO we should switch to 2.0 and add the return types to all the relevant classes. /cc @clue
There was a problem hiding this comment.
@WyriHaximus #541 was not what you expect?
There was a problem hiding this comment.
@L3o-pold Aside from a few things, yes that should have worked.
There was a problem hiding this comment.
@WyriHaximus can you clarify what so we can move forward?
Requires php: ^7.2 || ^8.0, but still allowing usage of ^1.0 maintains backwards compatibility with the current PHP requirements
Closes #513