Sample code for the article on set comprehension #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahjelle
reviewed
Nov 8, 2024
python-set-comprehension/colors.py
Outdated
| @@ -0,0 +1,4 @@ | |||
| colors = {"blue", "red", "green", "orange"} | |||
Contributor
There was a problem hiding this comment.
Should we add the duplicate green for consistency?
python-set-comprehension/emails.py
Outdated
| @@ -0,0 +1,11 @@ | |||
| emails = [ | |||
Contributor
There was a problem hiding this comment.
Should we start with a set here, like we now do in the tutorial?
python-set-comprehension/tools.py
Outdated
Comment on lines
7
to
8
| print("Numpy".lower() in tools_set) | ||
| print("Numpy".lower() in tools_set) |
Contributor
There was a problem hiding this comment.
There is a duplicate line here
gahjelle
approved these changes
Nov 12, 2024
brendaweles
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: