Skip to content

Conversation

@lpozo
Copy link
Contributor

@lpozo lpozo commented Mar 13, 2025

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpozo . I've updated some of the files directly while working through the tutorial. You can see my changes in this commit

Hope that's helpful, otherwise of course feel free to revert the changes if I messed something up accidentally or if you want to apply any of the fixes differently.

I tried to do only those that seemed obvious to me, and also added files where you had longer REPL sessions that seemed like it could be interesting to have part of the materials repo.

Like said, meant to speed this up but feel totally free to revert all of it, or change/remove parts you don't like :)

@martin-martin
Copy link
Contributor

@lpozo I applied some more changes. Take a look and let me know if you want to change anything. Thanks!

@lpozo
Copy link
Contributor Author

lpozo commented Mar 19, 2025

LGTM!

@brendaweles brendaweles merged commit a0f3307 into master Mar 25, 2025
1 check passed
@brendaweles brendaweles deleted the python-dict-attribute branch March 25, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants