Skip to content

make resolveClassReflection non-nullable as always passed a node #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jan 15, 2026
+1 −9
Merged

make resolveClassReflection non-nullable as always passed a node #7833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,6 @@ private function shouldSkipPropertyType(Type $propertyType): bool

private function hasSomeUntypedProperties(Class_ $class): bool
{
if ($class->getProperties() === []) {
return false;
}

foreach ($class->getProperties() as $property) {
if ($property->type instanceof Node) {
continue;
Expand Down
6 changes: 1 addition & 5 deletions src/Reflection/ReflectionResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,8 @@ public function resolveClassAndAnonymousClass(ClassLike $classLike): ClassReflec
return $this->reflectionProvider->getClass($className);
}

public function resolveClassReflection(?Node $node): ?ClassReflection
public function resolveClassReflection(Node $node): ?ClassReflection
{
if (! $node instanceof Node) {
return null;
}

$scope = $node->getAttribute(AttributeKey::SCOPE);
if (! $scope instanceof Scope) {
return null;
Expand Down