Skip to content

Fix step behavior for beginless ranges in Ruby 3.4+ #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

kojix2
Copy link
Member

@kojix2 kojix2 commented May 3, 2025

This pull request will allow the test to pass in Ruby 3.4.
Currently the test fails on Ruby 3.4.

irb(main):001> (nil..nil).step(-1)
(irb):1:in 'Range#step': #step for non-numeric beginless ranges is meaningless (ArgumentError)

See ruby/ruby#7444

@kojix2
Copy link
Member Author

kojix2 commented May 3, 2025

Ubuntu 20.04 has been removed from GitHub Actions.

ubuntu-20.04/3.4/3.x-x64
This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101

@kojix2
Copy link
Member Author

kojix2 commented May 3, 2025

The combination of Ubuntu 22.04 and Python 3.6 is no longer available.

@kojix2
Copy link
Member Author

kojix2 commented May 3, 2025

Tests now pass

@kou
Copy link
Member

kou commented May 3, 2025

We're working on this in #191 .

Could you open a separated PR only for ubuntu-20.04?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants