Draft: Ghidra instruction decode fails if the VLE register is available but the value is null. #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs-jacob
requested changes
Sep 9, 2024
disassemblers/ofrak_ghidra/ofrak_ghidra/ghidra_scripts/GetInstructions.java
Outdated
Show resolved
Hide resolved
Member
|
Also if there is a specific binary that triggers this null pointer exception, should we write a test to catch regressions? No need to block this PR on that if it's complicated, but if it's easy to do, we should add it in. |
…ructions.java Co-authored-by: Jacob Strieb <[email protected]>
whyitfor
changed the title
Contributor
|
Marked as draft to make it clear this is a WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fall back to PPC instruction encoding when the VLE register is available but the value is null.
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?