-
Notifications
You must be signed in to change notification settings - Fork 70
Started the collections readme #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Going to review the docs linked and will look at it at the next meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks overall good and meaningful but there is still quite a lot to discuss (which proves that it's meaningful 😄).
For the future, better create one PR for each new recommendation, it'll make reviewing/merging easier.
Closes #32 |
@bontreger could you find time to finalize this PR? It blocks #55 |
Co-authored-by: Eric L. <[email protected]>
Co-authored-by: Eric L. <[email protected]>
Ready for further review now. |
Thanks for your effort, looks good to me, I assume that we'll merge tomorrow. |
merged in the CoP meeting |
No description provided.