Skip to content

Started the collections readme #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Conversation

bontreger
Copy link
Contributor

No description provided.

@jscar-hawk
Copy link
Collaborator

Going to review the docs linked and will look at it at the next meeting

Copy link
Contributor

@ericzolf ericzolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks overall good and meaningful but there is still quite a lot to discuss (which proves that it's meaningful 😄).
For the future, better create one PR for each new recommendation, it'll make reviewing/merging easier.

@ericzolf
Copy link
Contributor

Closes #32

@ericzolf
Copy link
Contributor

@bontreger could you find time to finalize this PR? It blocks #55

@bontreger
Copy link
Contributor Author

Ready for further review now.

@bontreger bontreger requested a review from ericzolf March 25, 2022 14:44
@ericzolf
Copy link
Contributor

ericzolf commented Apr 5, 2022

Thanks for your effort, looks good to me, I assume that we'll merge tomorrow.

@mophahr mophahr merged commit a454408 into redhat-cop:main Apr 6, 2022
@mophahr
Copy link
Contributor

mophahr commented Apr 6, 2022

merged in the CoP meeting

@bontreger bontreger deleted the patch-6 branch April 20, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants