Skip to content

Fix typo #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix typo #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6246acc
Fix typos on README file
exe-r Jul 4, 2023
65410ef
Fix typo within code
exe-r Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ A such annotated secret looks like the following:

## Alerting when a certificate is about to expire

This operator can generate Prometheus alerts and/or Kubernetes events when a certifciate is about to expire.
This operator can generate Prometheus alerts and/or Kubernetes events when a certificate is about to expire.

### Generating prometheus alerts

Prometheus alerts are generated for all certificates. In order for the certifciate metrics to be collected and the alerts be generated the Prometheus CRs deployed with this operator must be honored by a [Prometheus operator](https://github.com/prometheus-operator/prometheus-operator). If you are running on OpenShift just add the label ``openshift.io/cluster-monitoring="true"`` to the namespace containing the operator.
Prometheus alerts are generated for all certificates. In order for the certificate metrics to be collected and the alerts be generated the Prometheus CRs deployed with this operator must be honored by a [Prometheus operator](https://github.com/prometheus-operator/prometheus-operator). If you are running on OpenShift just add the label ``openshift.io/cluster-monitoring="true"`` to the namespace containing the operator.

The following metrics will be collected for every tls secret:

Expand All @@ -110,8 +110,8 @@ The following metrics will be collected for every tls secret:
| `cert:validity_duration:sec` | duration of the certificate validity in seconds |
| `cert:time_to_expiration:sec` | time left to expiration in seconds |

Alerts will be generated at 85% and 95% of the certifciate lifetime.
Alerts are generated for all certificates including certifciate that are possibly automatically rotated. This is intentional as the automation that rotates the certificates may be non-functioning.
Alerts will be generated at 85% and 95% of the certificate lifetime.
Alerts are generated for all certificates including certificate that are possibly automatically rotated. This is intentional as the automation that rotates the certificates may be non-functioning.

If these alerts are not useful in your deployment, you can be silenced them in alert-manager as described [here](https://prometheus.io/docs/alerting/latest/configuration/#inhibit_rule).

Expand Down
2 changes: 1 addition & 1 deletion controllers/route/route_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ func (e *enqueueRequestForReferecingRoutes) Generic(evt event.GenericEvent, q wo
func populateRouteWithCertifcates(route *routev1.Route, secret *corev1.Secret) bool {
shouldUpdate := false
if route.Spec.TLS.Termination == "edge" || route.Spec.TLS.Termination == "reencrypt" {
// here we need to replace the terminating certifciate
// here we need to replace the terminating certificate
if value, ok := secret.Data[util.Key]; ok && len(value) != 0 {
if route.Spec.TLS.Key != string(value) {
route.Spec.TLS.Key = string(value)
Expand Down
2 changes: 1 addition & 1 deletion controllers/secrettokeystore/secret_to_keystore_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func (r *SecretToKeyStoreReconciler) getTrustStoreFromSecret(secret *corev1.Secr
},
})
if err != nil {
r.Log.Error(err, "unable to set trusted certifciate entry")
r.Log.Error(err, "unable to set trusted certificate entry")
return []byte{}, err
}
// increment counter
Expand Down