-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to networking role #126
Updates to networking role #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, except for a small change needed in the README. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking, I think we can use only one security group and define 2 variables ec2_security_group_inbound_rules
for internal (inbound) accesses and ec2_security_group_outbound_rules
for external (outbound) accesses
Backport to stable-3: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 54652e2 on top of patchback/backports/stable-3/54652e2eb0b7d5110202114751f3da7992595da3/pr-126 Backporting merged PR #126 into main
🤖 @patchback |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #144 🤖 @patchback |
Updates to networking role (cherry picked from commit 54652e2)
…54652e2eb0b7d5110202114751f3da7992595da3/pr-126 [PR #126/54652e2e backport][stable-3] Updates to networking role
This PR proposes some updates to the new
ec2_networking_resources
role:These changes are being proposed because this role is intended to create all of the necessary network resources for an EC2 instance; but currently some resources are being created here and some are being created in the new (proposed)
ec2_instance_create_delete
role. With these changes all of the network resource creation will be consolidated in this role.