Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to networking role #126

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

hakbailey
Copy link
Collaborator

This PR proposes some updates to the new ec2_networking_resources role:

  • Add optional creation of an external security group, with default rules to allow all HTTP and HTTPS traffic
  • Add optional creation of an internet gateway and routing traffic to it.
  • Add a delete option to allow easy removal of the resources created by this role.

These changes are being proposed because this role is intended to create all of the necessary network resources for an EC2 instance; but currently some resources are being created here and some are being created in the new (proposed) ec2_instance_create_delete role. With these changes all of the network resource creation will be consolidated in this role.

@hakbailey hakbailey requested review from GomathiselviS and gravesm and removed request for GomathiselviS December 4, 2024 20:47
Copy link
Contributor

@GomathiselviS GomathiselviS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, except for a small change needed in the README. Thank you!

Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, I think we can use only one security group and define 2 variables ec2_security_group_inbound_rules for internal (inbound) accesses and ec2_security_group_outbound_rules for external (outbound) accesses

@hakbailey hakbailey requested a review from abikouo December 5, 2024 16:54
@hakbailey hakbailey merged commit 54652e2 into redhat-cop:main Dec 5, 2024
23 checks passed
@hakbailey hakbailey deleted the update-ec2-networking-role branch December 5, 2024 18:28
Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 54652e2 on top of patchback/backports/stable-3/54652e2eb0b7d5110202114751f3da7992595da3/pr-126

Backporting merged PR #126 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/redhat-cop/cloud.aws_ops.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-3/54652e2eb0b7d5110202114751f3da7992595da3/pr-126 upstream/stable-3
  4. Now, cherry-pick PR Updates to networking role #126 contents into that branch:
    $ git cherry-pick -x 54652e2eb0b7d5110202114751f3da7992595da3
    If it'll yell at you with something like fatal: Commit 54652e2eb0b7d5110202114751f3da7992595da3 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 54652e2eb0b7d5110202114751f3da7992595da3
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Updates to networking role #126 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-3/54652e2eb0b7d5110202114751f3da7992595da3/pr-126
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/54652e2eb0b7d5110202114751f3da7992595da3/pr-126

Backported as #144

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 24, 2025
Updates to networking role

(cherry picked from commit 54652e2)
abikouo added a commit that referenced this pull request Jan 24, 2025
…54652e2eb0b7d5110202114751f3da7992595da3/pr-126

[PR #126/54652e2e backport][stable-3] Updates to networking role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants