-
Notifications
You must be signed in to change notification settings - Fork 175
Updated install plan approver #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Updated install plan approver #243
Conversation
install and manage operators setup for manual approval
|
It looks like the linting is flagging a few issues. It looks like there are a few spelling errors but also some words that are probably missing from the .wordlist-md file there. If you have any issues or questions with those let me know. It looks like the yaml linting also flagged a few minor issues which should hopefully be fairly easily to resolve. For functionality I will defer to @pittar! Thank you for the contribution! |
|
Thanks all! I'll take a look at these items this afternoon when I have a
few minutes and try to get it cleaned up and meeting standards.
…-Matt
On Fri, Sep 8, 2023 at 10:38 AM Trevor Royer ***@***.***> wrote:
It looks like the linting is flagging a few issues.
It looks like there are a few spelling errors but also some words that are
probably missing from the .wordlist-md
<https://github.com/redhat-cop/gitops-catalog/blob/main/.wordlist-md>
file there. If you have any issues or questions with those let me know.
It looks like the yaml linting also flagged a few minor issues which
should hopefully be fairly easily to resolve.
For functionality I will defer to @pittar <https://github.com/pittar>!
—
Reply to this email directly, view it on GitHub
<#243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQSAOV5QP72IXT4IYW34VLXZMUWNANCNFSM6AAAAAA4QO4RX4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
MATT ERTEL
Sr. Architect, RHCE
Red Hat Charleston <https://www.redhat.com/>
***@***.*** Phone: 8658980926
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
|
|
I've added a commit to fix the spelling issues (looks like this will still fail because of tech terms that are being identified incorrectly) |
pittar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update!
This branch contains a new version of a Kustomize Install Plan approver that acts as a template that allows for more control of operator install and upgrades when in manual approval mode and using ArgoCD.