Skip to content

Conversation

@mertel-rh
Copy link

This branch contains a new version of a Kustomize Install Plan approver that acts as a template that allows for more control of operator install and upgrades when in manual approval mode and using ArgoCD.

install and manage operators setup for manual approval
@strangiato
Copy link
Contributor

strangiato commented Sep 8, 2023

It looks like the linting is flagging a few issues.

It looks like there are a few spelling errors but also some words that are probably missing from the .wordlist-md file there. If you have any issues or questions with those let me know.

It looks like the yaml linting also flagged a few minor issues which should hopefully be fairly easily to resolve.

For functionality I will defer to @pittar!

Thank you for the contribution!

@mertel-rh
Copy link
Author

mertel-rh commented Sep 8, 2023 via email

@mertel-rh
Copy link
Author

I've added a commit to fix the spelling issues (looks like this will still fail because of tech terms that are being identified incorrectly)
I've also added a commit to fix the yaml lint error in the operatorgroup file. I see that another file, which I did not commit and is in another folder, is also failing so the yaml lint may continue to fail as well
Please let me know if there is anything else I can do to ensure the code quality requirements are met.

Copy link
Collaborator

@pittar pittar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants