Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix license + docker usage #43

Merged
merged 3 commits into from
Feb 14, 2024
Merged

fix license + docker usage #43

merged 3 commits into from
Feb 14, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Feb 14, 2024 •
edited
Loading

  • Change license to Apache
  • Remove Docker
  • Change Dockerfile with Containerfile
  • Link to new repository url

@feloy feloy requested a review from benoitf February 14, 2024 06:45
jeffmaury
jeffmaury requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some source file refers to EPL and some of them are missing header, time to add it

README.md Outdated

License
=======
EPL 2.0, See [LICENSE](LICENSE) for more information.
Apache, See [LICENSE](LICENSE) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Apache, See [LICENSE](LICENSE) for more information.
Apache 2.0, See [LICENSE](LICENSE) for more information.

benoitf
benoitf reviewed Feb 14, 2024
View reviewed changes
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @jeffmaury said, you've other files containing the license
https://github.com/search?q=repo%3Aredhat-developer%2Fpodman-desktop-image-checker-openshift-ext%20EPL&type=code

(and some of them are missing)

@feloy feloy requested review from benoitf and jeffmaury February 14, 2024 08:49
benoitf
benoitf approved these changes Feb 14, 2024
View reviewed changes
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏

jeffmaury
jeffmaury approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feloy feloy merged commit 8055f1c into redhat-developer:main Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@lstocchi lstocchi Awaiting requested review from lstocchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feloy @benoitf @jeffmaury