Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit lines in code blocks to 80 cols in README #51

Merged
merged 1 commit into from
May 2, 2024
Merged

limit lines in code blocks to 80 cols in README #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ USER root

with this printed message
```
USER directive set to root at line 28 could cause an unexpected behavior. In OpenShift, containers are run using arbitrarily assigned user ID
USER directive set to root at line 28 could cause an unexpected behavior.
In OpenShift, containers are run using arbitrarily assigned user ID
```

### Run Directive
Expand All @@ -36,8 +37,12 @@ RUN chmod 700 /app

with this printed message
```
permission set on chmod 700 /app at line 10-18 could cause an unexpected behavior. Is it an executable file? Try updating permissions to 770 otherwise set it to 760
Explanation - in Openshift, directories and files need to be read/writable by the root group and files that must be executed should have group execute permissions
permission set on chmod 700 /app at line 10-18 could cause an unexpected
behavior. Is it an executable file? Try updating permissions to 770 otherwise
set it to 760
Explanation - in Openshift, directories and files need to be read/writable
by the root group and files that must be executed should have group execute
permissions
```

#### chown
Expand All @@ -51,8 +56,8 @@ RUN chown -R node:node /app

with this printed message
```
owner set on chown -R node:node /app at line 10-18 could cause an unexpected behavior.
In OpenShift the group ID must always be set to the root group (0)
owner set on chown -R node:node /app at line 10-18 could cause an unexpected
behavior. In OpenShift the group ID must always be set to the root group (0)
```

#### sudo/su
Expand All @@ -66,9 +71,9 @@ RUN sudo node -v

with this printed message
```
sudo/su command used in 'sudo node -v' at line 26 could cause an unexpected behavior.
In OpenShift, containers are run using arbitrarily assigned user ID and elevating privileges could lead
to an unexpected behavior
sudo/su command used in 'sudo node -v' at line 26 could cause an unexpected
behavior. In OpenShift, containers are run using arbitrarily assigned user ID
and elevating privileges could lead to an unexpected behavior
```

### Expose directive
Expand All @@ -82,7 +87,8 @@ EXPOSE 80

with this printed message
```
port 80 exposed at line 28 could be wrong. TCP/IP port numbers below 1024 are privileged port numbers
port 80 exposed at line 28 could be wrong. TCP/IP port numbers below 1024 are
privileged port numbers
```

Cli
Expand Down
Loading