Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added image checker extension installation tests #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: added image checker extension installation tests #61

wants to merge 1 commit into from

Conversation

rostalan
Copy link
Contributor

@rostalan rostalan commented Dec 2, 2024 •
edited
Loading

Added image checker extension installation tests (OCI version) as per #57

@rostalan rostalan requested a review from a team as a code owner December 2, 2024 13:32
@rostalan rostalan changed the title test: added image checker extension verification tests test: added image checker extension installation tests Dec 2, 2024
odockal
odockal requested changes Dec 2, 2024
View reviewed changes
jeffmaury
jeffmaury reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I have 2 questions:

  • is the switch to module related to this PR ? I have the feeling it should be a separate PR
  • when running the tests, I noticed the report reported a skipped test is this expected ?

benoitf
benoitf requested changes Jan 27, 2025
View reviewed changes
Copy link

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as Jeff mentionned, all changes to the main package.json should be done prior to just the e2e part

@rostalan
Copy link
Contributor Author

rostalan commented Jan 27, 2025 •
edited
Loading

Opened a separate pr for the package.json: #63

@rostalan rostalan force-pushed the e2e-test branch 2 times, most recently from 7740929 to 53f4e4c Compare February 18, 2025 11:20
@rostalan
Copy link
Contributor Author

Separate PR for switch to ES modules: #65

@rostalan
Copy link
Contributor Author

rebased, ready for review @odockal @jeffmaury @benoitf

jeffmaury
jeffmaury reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the dependency update in yarn.lock should be part of this PR

@jeffmaury jeffmaury requested review from benoitf and odockal March 11, 2025 07:36
odockal
odockal approved these changes Mar 18, 2025
View reviewed changes
Copy link

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odockal odockal requested a review from jeffmaury March 18, 2025 12:03
jeffmaury
jeffmaury approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

@odockal odockal odockal approved these changes

@feloy feloy Awaiting requested review from feloy feloy is a code owner automatically assigned from redhat-developer/podman-desktop-reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from redhat-developer/podman-desktop-reviewers

@benoitf benoitf Awaiting requested review from benoitf

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rostalan @benoitf @jeffmaury @odockal