Conversation
|
This relates to RPOPC-762 |
grdumas
requested changes
Jan 19, 2026
grdumas
previously approved these changes
Jan 26, 2026
Collaborator
grdumas
left a comment
grdumas
left a comment
There was a problem hiding this comment.
Latest changes look good overall. I might want to add some degree of error handling in the event that the results file doesn't exist or value extraction fails for some reason, but that could be a future enhancement and does not need to block merging.
grdumas
added
the
group_review_lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It fixes the original pcp submission so we know report actual values.
Also adds timestamps, and switches from colons to , for field separator
Before/After Comparison
before
o.w.iteration o.w.running o.w.numthreads o.w.runtime o.w.throughput o.w.latency
13:55:40 N/A N/A N/A N/A N/A N/A
13:55:41 0.000 0.000 0.000 NaN NaN NaN
13:55:42 0.000 0.000 0.000 NaN NaN NaN
13:55:43 0.000 0.000 0.000 NaN NaN NaN
13:55:44 0.000 0.000 0.000 NaN NaN NaN
13:55:45 0.000 0.000 0.000 NaN NaN NaN
13:55:46 0.000 0.000 0.000 NaN NaN NaN
13:55:47 0.000 0.000 0.000 NaN NaN NaN
13:55:48 0.000 0.000 0.000 NaN NaN NaN
13:55:49 0.000 0.000 0.000 NaN NaN NaN
13:55:50 0.000 0.000 0.000 NaN NaN NaN
13:55:51 0.000 0.000 0.000 NaN NaN NaN
<continues, no data>
After
o.w.iteration o.w.multicore o.w.core o.w.nnet_test o.w.cjpegrose7preset o.w.loopsallmid10ksp o.w.parser125k o.w.radix2big64k o.w.shatest o.w.ziptest o.w.CoreMarkPRO o.w.linear_algmid100x100sp
15:01:35 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 NaN 147.930
15:01:36 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 NaN 147.930
15:01:37 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 NaN 147.930
15:01:38 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 5265.550 147.930
15:01:39 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 5265.550 147.930
15:01:40 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 5265.550 147.930
15:01:41 1.000 0.000 1.700 7.410 147.060 6.370 34.480 609.010 192.310 125.000 5265.550 147.930
Clerical Stuff
This closes #51
Relates to JIRA: RPOPC-762
Test information
Command executed
/home/ec2-user/workloads/coremark_pro-wrapper-2.1/coremark_pro/coremark_pro_run --run_user ec2-user --home_parent /home --iterations 1 --tuned_setting tuned_none_sys_file_ --host_config "m5.xlarge" --sysname "m5.xlarge" --sys_type aws --no-overrides --use_pcp
CSV File
Test,Multi iterations,Single Iterations,Scaling,Start_Date,End_Date
cjpeg-rose7-preset,1250.00,227.27,5.50,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
core,13.72,2.68,5.12,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
linear_alg-mid-100x100-sp,1219.51,320.51,3.80,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
loops-all-mid-10k-sp,49.21,11.30,4.35,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
nnet_test,54.95,14.62,3.76,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
parser-125k,444.44,62.50,7.11,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
radix2-big-64k,5847.95,987.17,5.92,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
sha-test,1000.00,357.14,2.80,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
zip-test,888.89,200.00,4.44,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
Score,42593.26,9262.65,0,0,2026-01-27T19:03:08Z,2026-01-27T19:03:40Z
===============================
partial pcp output
19:03:52 1.000 1.000 NaN NaN NaN NaN 1.000 1250.000 13.720 1219.510 49.210 54.950 444.440 5847.950 1000.000 888.890 42593.260
===========================================
Screenoutput from test
coremark_pro.txt