Skip to content

fix: Replace deprecated lvdisplay with pvs for LVM detection in detect_mounts #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayalibhavsar merged 3 commits into from
Aug 14, 2026
Merged

fix: Replace deprecated lvdisplay with pvs for LVM detection in detect_mounts #198

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cb75e1
fix: Replace deprecated lvdisplay with pvs for LVM detection in detec…
sayalibhavsar Jul 24, 2026
c87d030
fix: Fail closed when pvs query fails in detect_mounts
sayalibhavsar Jul 30, 2026
630cc9b
fix: exit immediately on pvs failure instead of falling through grep …
sayalibhavsar Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions detect_mounts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,29 @@ fi
mount_tmp=`mktemp /tmp/mount_temp.XXXXX`
mount | cut -d' ' -f1 > $mount_tmp
#
# Now lvms
# Any disk that is an LVM physical volume is in use — even if no
# LV on it is currently mounted. A benchmark (fio, iozone, etc.)
# writing to that disk would destroy the volume group.
#
if [[ -d /dev/mapper ]]; then
pushd /dev/mapper > /dev/null
for i in `ls | grep -v control`; do
value=`lvdisplay --maps /dev/mapper/$i | grep "Physical volume" | cut -d'/' -f2-`
echo /$value >> $mount_tmp
done
popd > /dev/null
if command -v pvs &>/dev/null; then
pv_output=$(pvs --noheadings -o pv_name 2>&1)
if [ $? -ne 0 ]; then
echo "Error: pvs query failed: $pv_output" >&2
Comment thread
sayalibhavsar marked this conversation as resolved.
for var in "$@"; do
echo "$var" >> $mount_tmp
done
else
for pv in $(echo "$pv_output" | awk '{print $1}'); do
echo "$pv" >> $mount_tmp
pv_base=${pv#/dev/}
if [[ $pv_base =~ ^nvme || $pv_base =~ ^mmcblk ]]; then
pv_base=$(echo "$pv_base" | sed 's/p[[:digit:]]*$//')
else
pv_base=$(echo "$pv_base" | sed 's/[[:digit:]]*$//')
fi
echo "/dev/$pv_base" >> $mount_tmp
done
fi
fi
#
# Now check for mounted
Expand Down
Loading