Skip to content

Conversation

@vishal-bala
Copy link
Member

@vishal-bala vishal-bala commented Dec 10, 2025

Closes #125

This PR implements customizable key prefixes for checkpoint saving (largely aligned to how they were implemented for stores in #101).

@vishal-bala vishal-bala self-assigned this Dec 10, 2025
Copy link
Contributor

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need change the the isolation tests (test_custom_checkpoint_prefix_isolation_sync) to:

  • Not start each tests with a fresh Redis container
  • Not have the Savers created sequentially, but instead do it concurrently in the same instance

Something along the lines of:

 with RedisSaver.from_conn_string(redis_url, checkpoint_prefix="app1_cp") as saver1:
          saver1.setup()
          with RedisSaver.from_conn_string(redis_url, checkpoint_prefix="app2_cp") as saver2:
              saver2.setup()
              # Both savers should be able to use their own indexes independently

@bsbodden bsbodden self-requested a review December 12, 2025 14:55
Copy link
Contributor

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@bsbodden bsbodden changed the title Enable custom prefixes for checkpoint savers feat: Enable custom prefixes for checkpoint savers (#125) Dec 12, 2025
@bsbodden bsbodden merged commit 303d4e7 into main Dec 12, 2025
17 checks passed
@vishal-bala vishal-bala deleted the feat/RAAE-1287/checkpoint-custom-prefix branch December 12, 2025 15:18
bsbodden added a commit that referenced this pull request Dec 12, 2025
Release 0.3.0 includes:

Features:
- Custom prefixes for checkpoint savers (#125, #127)
@bsbodden bsbodden mentioned this pull request Dec 12, 2025
bsbodden added a commit that referenced this pull request Dec 12, 2025
Release 0.3.0 includes:

Features:
- Custom prefixes for checkpoint savers (#125, #127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Redis key format/prefix

3 participants