Skip to content

Conversation

@pd-redis
Copy link
Collaborator

This pull request refactors the notifications system in the UI to improve modularity, maintainability, and user experience. The main changes include splitting notification logic into custom hooks, introducing a dedicated component for infinite notifications, and updating toast handling to support multiple containers and better queue management.

Notifications system refactor:

  • Extracted notification logic into custom hooks: useErrorNotifications, useMessageNotifications, and useInfiniteNotifications, improving separation of concerns and code readability.

Infinite notifications improvements:

  • Added a new InfiniteNotifications component to handle infinite notifications with a queue and timed dismissals, using a dedicated container.
  • The implementation is still not up to par with EUI implementation since redis-ui component lacks the ability to update contents of the toast, which EUI does by default, therefore pushing repeating notifications is visible for the user by removing and adding back the toast.
  • potential further improvement would be to compare new notifications with the one that is currently rendered and skip it if it is the same

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.55% 20288/24578
🟡 Branches 67.85% 8759/12910
🟡 Functions 77.08% 5429/7043
🟢 Lines 82.96% 19866/23946

Test suite run success

5229 tests passing in 681 suites.

Report generated by 🧪jest coverage report action from 49f53b5

@pd-redis pd-redis mentioned this pull request Oct 29, 2025
@pd-redis pd-redis self-assigned this Oct 29, 2025
valkirilov
valkirilov previously approved these changes Oct 30, 2025
@pd-redis pd-redis merged commit 4ddfe38 into main Nov 4, 2025
18 checks passed
@pd-redis pd-redis deleted the fe/bugfix/RI-7634-notifications-main branch November 4, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants