Skip to content

Use "c" instead of "s" in sed to handle branch names with slashes#513

Merged
Peter-Sh merged 1 commit into
unstablefrom
fix_sed_module_replacement
Apr 8, 2026
Merged

Use "c" instead of "s" in sed to handle branch names with slashes#513
Peter-Sh merged 1 commit into
unstablefrom
fix_sed_module_replacement

Conversation

@Peter-Sh
Copy link
Copy Markdown
Contributor

@Peter-Sh Peter-Sh commented Apr 8, 2026

c would just replace whole string with literals folowing the command without involving regexp


Note

Low Risk
Small build-script change limited to Docker image module version patching; low blast radius aside from potential build-time differences if Makefile formatting varies.

Overview
Updates the Alpine and Debian Dockerfile.j2 templates to change how Redis module versions are injected during custom_build.

The sed commands that set MODULE_VERSION in module Makefiles now use the line-replace (c) form instead of a regex substitution, avoiding failures when version strings contain characters like / (e.g., branch names).

Reviewed by Cursor Bugbot for commit 724a0e9. Bugbot is set up for automated code reviews on this repo. Configure here.

c would just replace whole string with literals folowing the command without involving regexp
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented Apr 8, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@Peter-Sh Peter-Sh merged commit 46f1e05 into unstable Apr 8, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant