Use "c" instead of "s" in sed to handle branch names with slashes#513
Merged
Conversation
c would just replace whole string with literals folowing the command without involving regexp
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c would just replace whole string with literals folowing the command without involving regexp
Note
Low Risk
Small build-script change limited to Docker image module version patching; low blast radius aside from potential build-time differences if Makefile formatting varies.
Overview
Updates the Alpine and Debian
Dockerfile.j2templates to change how Redis module versions are injected duringcustom_build.The
sedcommands that setMODULE_VERSIONin module Makefiles now use the line-replace (c) form instead of a regex substitution, avoiding failures when version strings contain characters like/(e.g., branch names).Reviewed by Cursor Bugbot for commit 724a0e9. Bugbot is set up for automated code reviews on this repo. Configure here.