Skip to content

RS: Added mtls_trusted_ca to the certificates table #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Conversation

rrelledge
Copy link
Collaborator

@rrelledge rrelledge added the rs Redis Enterprise Software label Apr 16, 2025
@rrelledge rrelledge requested review from yoavredis and a team April 16, 2025 19:08
@rrelledge rrelledge self-assigned this Apr 16, 2025
Copy link
Contributor

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrelledge a few comments:

  1. If certain certificates are not auto-generated and are later uploaded (optionally) by the customer, then they most likely won't be "self-signed" certs. The whole point of "self-signed" certs is that the system generates them so that the customer won't have to supply its own.
  2. Per Eng, ldap_client and mtls_trusted_ca are not auto-generated by the cluster. Thus, the opening paragraph is misleading the reader into thinking that the system auto-generates self-signed certificates for the entire list.

I suggest to:

  • Add a 3rd column to the certificate list, indicating auto-generated yes/no
  • Explain that the list contains all the supported certificates.
    -- Some are auto-generated (self-signed) to be used OOTB, and could be replaced with customer's certs
    -- Some are not auto-generated which makes them optional. They must be provided by the customer for using the specific feature they are coupled with.

@rrelledge rrelledge requested a review from yoavredis April 17, 2025 17:20
Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrelledge now it's clear and accurate :)
LGTM, 10x.

@rrelledge rrelledge merged commit c6e5e0e into main Apr 21, 2025
5 checks passed
@rrelledge rrelledge deleted the DOC-1574 branch April 21, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rs Redis Enterprise Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants