Skip to content

Conversation

@rrelledge
Copy link
Collaborator

No description provided.

@rrelledge rrelledge requested review from a team and yoavredis December 3, 2025 02:23
@rrelledge rrelledge self-assigned this Dec 3, 2025
@rrelledge rrelledge added do not merge yet rs Redis Enterprise Software labels Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

DOC-5858

Copy link

@yoavredis yoavredis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrelledge it looks good :)
Left some comments.
10x

@avalov-r
Copy link

avalov-r commented Dec 3, 2025

@rrelledge
Could you also maybe document that it is possible to change the default SP address? This currently will not be possible through CM (@yoavredis correct me if wrong), but REST API supports this. This is crucial for K8 customers, as they most likely will need to change this.

Endpoint:
PUT /v1/cluster/sso
{
"service": {
"address": "http://something.com/"
}
}

Once this is changed, the metadata file and the SP login/logout URL and entity ID will change to reflect this new address, therefore this is a breaking change for existing SSO integrations.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM.

Minor suggestion (if you have time and think it would help) is that maybe you could add an interactive or hidden checklist for the pages where you have steps to follow? (Example of this is here: https://redis.io/docs/latest/integrate/redis-data-integration/data-pipelines/prepare-dbs/my-sql-mariadb/) The interactive version might be helpful to human users, but even if you use the hidden form of the checklist, it helps AI agents to understand the intention of the page. Purely optional, though - I'm not suggesting that it makes sense to have these everywhere :-)

@rrelledge
Copy link
Collaborator Author

@avalov-r

@rrelledge Could you also maybe document that it is possible to change the default SP address?

I added a new "Change SP address" section under "Update configuration": https://redis.io/docs/staging/DOC-5858/operate/rs/security/access-control/saml-sso/#change-sp-address. Does this seem okay?

@rrelledge rrelledge requested a review from yoavredis December 5, 2025 18:49
@rrelledge rrelledge changed the base branch from main to DOC-5854 December 5, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rs Redis Enterprise Software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants