-
Notifications
You must be signed in to change notification settings - Fork 288
RS: SAML SSO #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: DOC-5854
Are you sure you want to change the base?
RS: SAML SSO #2498
Conversation
…ST API reference
yoavredis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rrelledge it looks good :)
Left some comments.
10x
|
@rrelledge Endpoint: Once this is changed, the metadata file and the SP login/logout URL and entity ID will change to reflect this new address, therefore this is a breaking change for existing SSO integrations. |
andy-stark-redis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language LGTM.
Minor suggestion (if you have time and think it would help) is that maybe you could add an interactive or hidden checklist for the pages where you have steps to follow? (Example of this is here: https://redis.io/docs/latest/integrate/redis-data-integration/data-pipelines/prepare-dbs/my-sql-mariadb/) The interactive version might be helpful to human users, but even if you use the hidden form of the checklist, it helps AI agents to understand the intention of the page. Purely optional, though - I'm not suggesting that it makes sense to have these everywhere :-)
I added a new "Change SP address" section under "Update configuration": https://redis.io/docs/staging/DOC-5858/operate/rs/security/access-control/saml-sso/#change-sp-address. Does this seem okay? |
No description provided.