feat: add support for binary UUID encoding in scan#3725
Open
yash9263 wants to merge 1 commit into
Open
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Member
|
Hello @yash9263 , this would be a breaking change and we will look into including it in v10. Thank you! |
Author
|
Hi @ndyakov, thanks for taking a look. Please let me know if any changes are needed to get it ready for v10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3139
Adds support to read UUID via
encoding.BinaryUnmarshaler.Note
Medium Risk
Changes
hscanstruct field scanning behavior to preferencoding.BinaryUnmarshalerwhen present, which could affect existing types that implement multiple unmarshal interfaces. Impact is scoped to Redis hash/scan decoding paths but touches core decoding logic.Overview
Adds support for scanning Redis hash values into struct fields that implement
encoding.BinaryUnmarshaler, enabling binary UUID-style decoding duringScan/HGetAll().Scan().Updates the
hscanstruct scanner dispatch ininternal/hscan/structmap.goand adds coverage in bothinternal/hscan/hscan_test.goandcommands_test.goto validate round-tripping a 16-byte ID via binary marshal/unmarshal.Written by Cursor Bugbot for commit 815d7bc. This will update automatically on new commits. Configure here.