csc: Support standalone client#3794
Draft
ofekshenawa wants to merge 2 commits into
Draft
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
ndyakov
reviewed
Apr 27, 2026
ndyakov
left a comment
ndyakov
left a comment
Member
There was a problem hiding this comment.
took a brief look at this as well.
Comment on lines
+115
to
+135
| seen := make(map[uint64]struct{}, remaining) | ||
| borrowed := make([]*pool.Conn, 0, remaining) | ||
| for i := 0; i < remaining; i++ { | ||
| cn, err := c.connPool.Get(ctx) | ||
| if err != nil { | ||
| break | ||
| } | ||
| if _, dup := seen[cn.GetID()]; dup { | ||
| c.connPool.Put(ctx, cn) | ||
| break | ||
| } | ||
| seen[cn.GetID()] = struct{}{} | ||
| borrowed = append(borrowed, cn) | ||
| if err := c.peekAndProcessPushNotifications(ctx, cn); err != nil { | ||
| internal.Logger.Printf(ctx, "csc: error draining invalidations on cache hit: %v", err) | ||
| } | ||
| } | ||
| for _, cn := range borrowed { | ||
| c.connPool.Put(ctx, cn) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
this will be quite consuming for larger pools, let's discuss different approaches here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.