DOC-2553 - Adds code examples for the set tutorial#2582
Open
justincastilla wants to merge 2 commits intoredis:emb-examplesfrom
Open
DOC-2553 - Adds code examples for the set tutorial#2582justincastilla wants to merge 2 commits intoredis:emb-examplesfrom
justincastilla wants to merge 2 commits intoredis:emb-examplesfrom
Conversation
justincastilla
changed the title
dwdougherty
reviewed
Jan 16, 2024
| await client.del('bikes:racing:usa') | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sAdd |
There was a problem hiding this comment.
Unfortunately, case matters for step names.
Suggested change
| // STEP_START sAdd | |
| // STEP_START sadd |
dwdougherty
reviewed
Jan 16, 2024
| assert.equal(res4, 2) | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sIsMember |
There was a problem hiding this comment.
Suggested change
| // STEP_START sIsMember | |
| // STEP_START sismember |
dwdougherty
reviewed
Jan 16, 2024
| assert.equal(res6, false) | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sinster |
There was a problem hiding this comment.
Suggested change
| // STEP_START sinster | |
| // STEP_START sinter |
dwdougherty
reviewed
Jan 16, 2024
| assert.deepEqual(res7, [ 'bike:1' ]) | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sCard |
There was a problem hiding this comment.
Suggested change
| // STEP_START sCard | |
| // STEP_START scard |
dwdougherty
reviewed
Jan 16, 2024
| await client.del('bikes:racing:france') | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sAdd_sMembers |
There was a problem hiding this comment.
Suggested change
| // STEP_START sAdd_sMembers | |
| // STEP_START sadd_smembers |
dwdougherty
reviewed
Jan 16, 2024
| assert.deepEqual(res10.sort(), ['bike:1', 'bike:2', 'bike:3']) | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START smIsMember |
There was a problem hiding this comment.
Suggested change
| // STEP_START smIsMember | |
| // STEP_START smismember |
dwdougherty
reviewed
Jan 16, 2024
| assert.deepEqual(res12, [true, true, false]) | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sDiff |
There was a problem hiding this comment.
Suggested change
| // STEP_START sDiff | |
| // STEP_START sdiff |
dwdougherty
reviewed
Jan 16, 2024
| await client.del('bikes:racing:italy') | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START sRem |
There was a problem hiding this comment.
Suggested change
| // STEP_START sRem | |
| // STEP_START srem |
dwdougherty
suggested changes
Jan 16, 2024
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Added corrections to step case in multiple places. Please commit these changes. Otherwise, the docs build correctly.
sjpotter
reviewed
Jun 13, 2024
Comment on lines
+10
to
+11
| await client.del('bikes:racing:france') | ||
| await client.del('bikes:racing:usa') |
Contributor
There was a problem hiding this comment.
for consistency user flushdb
sjpotter
reviewed
Jun 13, 2024
Comment on lines
+40
to
+44
| const res5 = await client.sIsMember('bikes:racing:usa', 'bike:1') | ||
| console.log(res5) // >>> true | ||
|
|
||
| const res6 = await client.sIsMember('bikes:racing:usa', 'bike:2') | ||
| console.log(res6) // >>> false |
Contributor
There was a problem hiding this comment.
returns 1/0 not true/false (at least in v5)
sjpotter
reviewed
Jun 13, 2024
| console.log(res11) // >>> true | ||
|
|
||
| const res12 = await client.smIsMember('bikes:racing:france', ['bike:2', 'bike:3', 'bike:4']) | ||
| console.log(res12) // >>> [true, true, false] |
Contributor
There was a problem hiding this comment.
in v5, we now return 1/1/0 not true/true/false
|
This pull request has been automatically marked as stale due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds code examples for the Set tutorial
DOC-2553
https://redislabs.atlassian.net/browse/DOC-2295
Checklist
npm testpass with this change (including linting)?