Integrated Redis Cache and Redis Sessions into Redis OM Spring. #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
| try { | ||
| jsonValues = connection.sync().jsonGet(key); | ||
| } catch (NullPointerException e) { | ||
| // Workaround for Lettuce 6.5 bug: |
There was a problem hiding this comment.
we shouldn't need this anymore rihgt since we are using Lettuce 6.7.1.RELEASE?
| this.evictionLatency = Timer.builder("cache.evictions.latency").tag("name", name).description("Cache evictions") | ||
| .register(configuration.getMeterRegistry()); | ||
| if (configuration.isIndexEnabled()) { | ||
| createIndex(); |
There was a problem hiding this comment.
do we want to recreate the index every time RedisCache is instantiated? If this is running in multiple apps that come up and down in k8s pods for example it seems like it would be recreated a lot. Maybe check if its already created and in sync before dropping it?
| throw new IllegalArgumentException(String.format("unparseable point %s", s)); | ||
| } | ||
|
|
||
| return new GeoLoc(Double.parseDouble(parts[1]), Double.parseDouble(parts[1])); |
There was a problem hiding this comment.
is this a bug? Should it be parts[0] and parts[1]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing Redis Cache and Redis Sessions into Redis OM Spring.
To keep a standard and "all-in-one" naming convention:
com.redis.cachetocom.redis.om.cachecom.redis.sessionstocom.redis.om.sessions