Skip to content

Migrate from poetry to uv #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

tylerhutcherson
Copy link
Collaborator

Beyond poetry dependency resolution being the bane of my existence... uv is just better. Faster, stronger..

This PR introduces uv as our new package manager and greatly improves the economics of our testing CI workflow on a few fronts:

  • Updated versions of common actions
  • DRY(er) environment var setup
  • Isolated dependency installs during CI tests
  • Caching enabled for all of the things

@tylerhutcherson tylerhutcherson force-pushed the feat/RAAE-920-poetry-to-uv branch from 4e7471e to c19c0e1 Compare June 19, 2025 16:40
@tylerhutcherson tylerhutcherson changed the title Migrate from poetry to uv. Migrate from poetry to uv Jun 19, 2025
@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Jun 19, 2025
@tylerhutcherson tylerhutcherson requested a review from rbs333 June 19, 2025 21:49
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

  • Pulled local uv sync worked for me
  • Make additions worked
  • Pre-commit also working for local commit
  • Generally faster seems like an improvement

@@ -27,7 +27,8 @@ class SchemaValidationError(RedisVLError):
"""Error when validating data against a schema."""

def __init__(self, message, index=None):
if index is not None:
# Only add index prefix if the message doesn't already contain detailed validation info
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this is related to this pr

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yeah when I reran the notebooks, the messages for schema validation warnings were driving me insane. Meant to pull that into a separate commit/branch. I can remove.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can stay in just wasn't sure if you wanted it as part of this one or not :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same some nice adds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants